Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wpilibc] SysIdRoutineLog: Initialize m_stateInitialized #6359

Merged
merged 1 commit into from
Feb 10, 2024

Conversation

Kython89
Copy link
Contributor

Fixes the m_stateInitialized not being initialized which causes non deterministic behavior as to if the sysid-test-state- will appear in the log.

@Kython89 Kython89 requested a review from a team as a code owner February 10, 2024 15:15
@PeterJohnson
Copy link
Member

PeterJohnson commented Feb 10, 2024

It would be cleaner to do m_stateInitialized = false in the .h file declaration.

@PeterJohnson
Copy link
Member

You should revert the change to the .cpp file.

Fixes the m_stateInitialized not being initialized which causes non deterministic behavior as to if the `sysid-test-state-` will appear in the log.
@Kython89
Copy link
Contributor Author

Yes, sorry I was doing it all in the github interface. I couldn't figure out how to revert so I had to clone it then revert, squash. I think it's good now.

@PeterJohnson PeterJohnson changed the title Fixes stateInitialized var not being initialized. [wpilibc] SysIdRoutine: Initialize stateInitialized Feb 10, 2024
@PeterJohnson PeterJohnson changed the title [wpilibc] SysIdRoutine: Initialize stateInitialized [wpilibc] SysIdRoutineLog: Initialize m_stateInitialized Feb 10, 2024
@PeterJohnson PeterJohnson merged commit 300419c into wpilibsuite:main Feb 10, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants